Add initial C10S variant #1498
Add initial C10S variant #1498
Conversation
|
Do not merge as it includes changes that we do not want but that are here to test in CI (see commits). |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Hmm, almost seems like the logs are truncated... This is probably fallout from coreos/coreos-assembler#3785. |
I can't reproduce this locally, but I have a suspicion that `tail` can exit too quickly in some circumstances, causing truncated output: openshift/os#1498 (comment) coreos#3785 (comment) Rather than having an unconditional `sleep`, let's make it easier to test that theory by having an env var we can use to make it optional. Then we'll test that in CI. Mid-term, I'd like to revert 79b15c8 soon so we can go back to virtio-serial which is just so much cleaner.
|
Let's see if coreos/coreos-assembler#3792 helps (then here, we'd |
I can't reproduce this locally, but I have a suspicion that `tail` can exit too quickly in some circumstances, causing truncated output: openshift/os#1498 (comment) #3785 (comment) Rather than having an unconditional `sleep`, let's make it easier to test that theory by having an env var we can use to make it optional. Then we'll test that in CI. Mid-term, I'd like to revert 79b15c8 soon so we can go back to virtio-serial which is just so much cleaner.
|
/retest |
|
Ahh and indeed now we clearly see the error for all of them which means we were missing output. Yuck OK, so we need to fix the |
Thanks! I indeed had a missing change in those commits. |
|
Hum, the workaround is not that ugly and only impacts CI here so maybe we should merge it for now until we've fixed this COSA. |
|
CI fixes in openshift/release#51750 |
So far. :) It's racy so I don't see why it couldn't happen in the prod pipeline. I'd hate for someone to be debugging a failure there and working with incomplete output thinking the error is happening somewhere other than it really is. I guess though a major hack is to just add a |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
Failing on missing the teamd package. |
openshift-merge-robot
removed
the
needs-rebase
|
We'll need the prep work for coreos/fedora-coreos-tracker#1787 as well |
travier
force-pushed
the
c10s
branch
2 times, most recently
from
edaaa92
to
9c0b25a
Compare
travier
force-pushed
the
c10s
branch
3 times, most recently
from
b75b40a
to
760a329
Compare
This reverts commit 57f7494.
This reverts commit 57f7494.
Preparation work to update openshift/release jobs to build rhel 9.6 and c10s. Needs to be merged before openshift#1629 and openshift#1498
|
@travier: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
c9s: Point image-c9s to image-rhel-9.4
c9s: Use RPMs from 9.4 RHAOS repo
Revert "c9s.repo: temporarily use mirrored repos"
This reverts commit 88e41a0.
DoNotMerge: CI changes to test C10S builds
manifests: Add initial c10s based variant
See: #1466
kola-denylist.yaml: Update for c10s variant
c10s.repo: Skip GPG checks for now
Corresponding Fedora CoreOS changes: coreos/fedora-coreos-config#3015